Skip to content

refactor: minor cleanup #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

refactor: minor cleanup #605

merged 2 commits into from
Oct 29, 2024

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Oct 29, 2024

Those are all minor edits.
We can merge all/some/none.

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 040328c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@605

commit: 040328c

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 19.32% 1409 / 7290
🔵 Statements 19.32% 1409 / 7290
🔵 Functions 53.14% 93 / 175
🔵 Branches 67.13% 331 / 493
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/open-next/src/build/compileConfig.ts 0% 0% 0% 0% 1, 21-29, 31-36, 39-46, 48, 52-58, 60-62, 64-65, 67-73, 76, 78-98, 100-101, 103-109, 111-121
packages/open-next/src/build/copyTracedFiles.ts 0% 0% 0% 0% 1, 19, 21-25, 28-39, 41-43, 47-57, 59, 62-64, 67-76, 78-80, 82-93, 95-96, 98, 103-105, 107-118, 120-125, 127-131, 133-144, 146-147, 153, 155-157, 160-162, 164, 167-168, 171-173, 176-177, 179, 181-186, 189-191, 193-205, 207-210, 214, 216-225, 228, 234-236, 239-249, 253, 255-262, 264-287, 289-294, 296-297
packages/open-next/src/core/createGenericHandler.ts 0% 0% 0% 0% 1, 33, 37, 40-42, 44-46, 49, 52-53, 55-56
packages/open-next/src/core/createMainHandler.ts 0% 0% 0% 0% 1, 32, 34-36, 38-40, 42-43, 46, 48-50, 52, 54, 57, 60-62, 64, 66-67
packages/open-next/src/overrides/wrappers/cloudflare.ts 0% 100% 100% 0% 9, 13-15, 19-23, 25, 27, 29, 31-32, 34-39
packages/open-next/src/plugins/edge.ts 0% 0% 0% 0% 1, 32-49, 51-54, 56-61, 63-67, 71, 75-78, 82-88, 91-93, 96, 99-101, 142-151, 153-156, 158-166, 168, 182-189, 193-197
packages/open-next/src/plugins/replacement.ts 0% 0% 0% 0% 1, 15-16, 52-62, 64-77, 79-80, 82, 84-98, 100-106
Generated in workflow #663 for commit 040328c by the Vitest Coverage Report Action

conico974
conico974 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a few comment/question

@vicb vicb merged commit 9c5d582 into main Oct 29, 2024
3 checks passed
@vicb vicb deleted the minor branch October 29, 2024 11:19
@vicb vicb mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @conico974